Bug 106131 – Add a script to delete stale zero-byte build files

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Add a script to delete stale zero-byte bulid files

[Ryosuke Niwa]

Created attachment 181369 [details]
Patch

[Eric Seidel (no email)]

Which platform is this for?

[Nico Weber]

Comment on attachment 181369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181369&action=review

Looks fine to me, but I'm not a reviewer.

> Tools/BuildSlaveSupport/delete-stale-build-files:47
> +    if genericPlatform != 'mac':

eseidel: This suggestes it's for the apple port

> Tools/BuildSlaveSupport/delete-stale-build-files:54
> +    for root, dirs, files in os.walk(directory):

nit: Since you don't use dirs, you can do `for root, _, files in…` instead.

> Tools/BuildSlaveSupport/delete-stale-build-files:71
> +                exit_code += 1

I'd just do `= 1`

[Ryosuke Niwa]

(In reply to comment #2)
> Which platform is this for?

We’ll only do that for Mac port where we see zero-byte build files every now and then but we can certainly support other kinds of stale build files in the future (I think MSVC generates quite few of them).

[Tony Chang]

Comment on attachment 181369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181369&action=review

> Tools/ChangeLog:3
> +        Add a script to delete stale zero-byte bulid files

Typo: bulid -> build.

> Tools/BuildSlaveSupport/delete-stale-build-files:60
> +                if ext in ['.dep', '.timestamp', '.txt', '.html', '.js', '.generated'] or os.path.getsize(full_path):

Nit: Use a tuple instead of a list.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:146
> +    description = ["delete stale build files"]

Nit: "deleting stale build files" since this prints while the step is running.

[Ryosuke Niwa]

Created attachment 181391 [details]
Updated per comments

[Tony Chang]

Comment on attachment 181391 [details]
Updated per comments

View in context: https://bugs.webkit.org/attachment.cgi?id=181391&action=review

Seems fine as long as you're not seeing spurious rebuilds after running this.

> Tools/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

Nit: I would maybe mention that this is Apple Mac only for now.

[Ryosuke Niwa]

Committed r138888: <http://trac.webkit.org/changeset/138888>