Bug 106129

Summary:

Full screen mode should not exit when application resigns active state.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Jer Noble 2013-01-04 13:11:41 PST

Full screen mode should not exit when application resigns active state.

Comment 1 Jer Noble 2013-01-04 13:12:00 PST

<rdar://problem/12959244>

Comment 2 Jer Noble 2013-01-04 13:15:39 PST

Now that we use the NSWindow full screen API, and the full screen window gets its own space, there is no longer a reason to exit full screen mode when the application resigns active.

Comment 3 Jer Noble 2013-01-04 13:21:05 PST

Created attachment 181367 [details]
Patch

Comment 4 Darin Adler 2013-02-25 10:04:53 PST

Comment on attachment 181367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181367&action=review

> Source/WebKit2/ChangeLog:8
> +        Remove the applicationDidResignActive: notification from WKFullScreenWindowController.

Chang log should say why, not just what is changing.

Comment 5 Jer Noble 2013-02-25 15:45:26 PST

Updated the change log to read:

Now that full screen windows get their own full screen space, there is no reason to exit full
screen mode when the application resigns active state. Instead, the windowserver will bring the
space containing the newly active application to the foreground. The user can then swipe back
to the full screen space (or use Mission Control) to get back to the full screen window.

Comment 6 Jer Noble 2013-02-25 15:50:13 PST

Committed r143982: <http://trac.webkit.org/changeset/143982>