Bug 106125 – Make seamless iframes paginate properly in printing, columns and regions

• Component: Frames
• Status: RESOLVED FIXED

[Dave Hyatt]

Teach seamless iframes how to be paginated in their parent document.

[Dave Hyatt]

Created attachment 181361 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 181361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181361&action=review

Thanks for the fix.

> Source/WebCore/rendering/RenderView.cpp:160
> +static RenderBox* enclosingSeamlessRenderer(Element* ownerElement)

I'm a little surprised you didn't use Document::seamlessParentIFrame() and just grab the renderer off of that?

> Source/WebCore/rendering/RenderView.cpp:201
> +    RenderBox* seamlessAncestor = enclosingSeamlessRenderer(document()->ownerElement());
> +    LayoutState* seamlessLayoutState = seamlessAncestor ? seamlessAncestor->view()->layoutState() : 0;
> +    bool shouldInheritPagination = seamlessLayoutState && !m_pageLogicalHeight && seamlessAncestor->style()->writingMode() == style()->writingMode();

It's unclear what properties seamless iframes should inherit or not.  You might want to take a peak at PassRefPtr<RenderStyle> StyleResolver::styleForDocument(Document* document, CSSFontSelector* fontSelector)'s handling of seamless if you haven't already.

[WebKit Review Bot]

Attachment 181361 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/rendering/RenderObject.cpp:1301:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderView.h:240:  The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 181380 [details]
Patch

New patch to incorporate Eric's suggestions and fix style issues.

[Build Bot]

Comment on attachment 181380 [details]
Patch

Attachment 181380 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15703502

New failing tests:
fast/regions/seamless-iframe-flowed-into-regions.html
fast/multicol/seamless-flowed-through-columns.html

[Dave Hyatt]

Landed in r143256.