Bug 106117

Summary: IndexedDB: Stub out IDBDatabaseBackendInterface::createIndex/deleteIndex
Product: WebKit Reporter: Alec Flett <alecflett>
Component: New BugsAssignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106377    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Alec Flett
Reported 2013-01-04 11:22:12 PST
IndexedDB: Stub out IDBDatabaseBackendInterface::createIndex/deleteIndex
Attachments
Patch (10.29 KB, patch)
2013-01-04 11:24 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch (10.35 KB, patch)
2013-01-04 13:15 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.35 KB, patch)
2013-01-04 13:15 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.91 KB, patch)
2013-01-04 13:54 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.91 KB, patch)
2013-01-04 13:55 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.35 KB, patch)
2013-01-04 13:57 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alec Flett
Comment 1 2013-01-04 11:24:52 PST
Created attachment 181343 [details] Patch
WebKit Review Bot
Comment 2 2013-01-04 11:29:58 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Alec Flett
Comment 3 2013-01-04 11:45:15 PST
abarth@ -r? pretty simple stuff.
Adam Barth
Comment 4 2013-01-04 11:56:00 PST
Comment on attachment 181343 [details] Patch ok
WebKit Review Bot
Comment 5 2013-01-04 12:31:28 PST
Comment on attachment 181343 [details] Patch Attachment 181343 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15702237
Alec Flett
Comment 6 2013-01-04 13:15:03 PST
Created attachment 181365 [details] Patch
Alec Flett
Comment 7 2013-01-04 13:15:53 PST
Created attachment 181366 [details] Patch for landing
WebKit Review Bot
Comment 8 2013-01-04 13:28:09 PST
Comment on attachment 181366 [details] Patch for landing Rejecting attachment 181366 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15710282
Alec Flett
Comment 9 2013-01-04 13:54:12 PST
Created attachment 181370 [details] Patch for landing
Alec Flett
Comment 10 2013-01-04 13:55:12 PST
Created attachment 181372 [details] Patch for landing
Alec Flett
Comment 11 2013-01-04 13:57:29 PST
Created attachment 181373 [details] Patch for landing
WebKit Review Bot
Comment 12 2013-01-05 12:23:28 PST
Comment on attachment 181373 [details] Patch for landing Clearing flags on attachment: 181373 Committed r138898: <http://trac.webkit.org/changeset/138898>
WebKit Review Bot
Comment 13 2013-01-05 12:23:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.