Bug 106113

Summary: [BlackBerry] Useless if statement check
Product: WebKit Reporter: gmak
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch with changelog
rwlbuis: review+, webkit.review.bot: commit-queue-
Patch - fixed changelog
rwlbuis: review+, webkit.review.bot: commit-queue-
patch again none

gmak
Reported 2013-01-04 10:59:05 PST
There appears to be a stray ! from refactoring. Luckily this doesn't have an effect on behaviour because its just a double check, but one day it might.
Attachments
Patch with changelog (2.26 KB, patch)
2013-01-04 11:24 PST, gmak 		rwlbuis: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch - fixed changelog (2.26 KB, patch)
2013-01-08 12:37 PST, gmak 		rwlbuis: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch again (2.23 KB, patch)
2013-01-09 11:11 PST, gmak 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
gmak
Comment 1 2013-01-04 11:24:20 PST
Created attachment 181342 [details] Patch with changelog
Rob Buis
Comment 2 2013-01-07 12:35:58 PST
Comment on attachment 181342 [details] Patch with changelog LGTM.
WebKit Review Bot
Comment 3 2013-01-07 12:38:07 PST
Comment on attachment 181342 [details] Patch with changelog Rejecting attachment 181342 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: it_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 succeeded at 4064 (offset 3 lines). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/ChangeLog.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15738842
gmak
Comment 4 2013-01-08 12:37:48 PST
Created attachment 181731 [details] Patch - fixed changelog Seems to be a chaneglog issue.
Rob Buis
Comment 5 2013-01-08 12:46:40 PST
Comment on attachment 181731 [details] Patch - fixed changelog Ok.
Rob Buis
Comment 6 2013-01-08 12:47:03 PST
Comment on attachment 181731 [details] Patch - fixed changelog Ok.
WebKit Review Bot
Comment 7 2013-01-08 13:18:56 PST
Comment on attachment 181731 [details] Patch - fixed changelog Rejecting attachment 181731 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: it_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 succeeded at 4064 (offset 3 lines). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/ChangeLog.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15762201
gmak
Comment 8 2013-01-09 11:11:49 PST
Created attachment 181954 [details] patch again
WebKit Review Bot
Comment 9 2013-01-09 12:42:33 PST
Comment on attachment 181954 [details] patch again Clearing flags on attachment: 181954 Committed r139225: <http://trac.webkit.org/changeset/139225>
WebKit Review Bot
Comment 10 2013-01-09 12:42:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.