Bug 106096

Summary: [WK2] Add support for setting IndexedDB database path in WK2
Product: WebKit Reporter: Michael Pruett <michael>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abecsi, alecflett, andersca, cmarcelo, gyuyoung.kim, jsbell, menard, rakuco, sam, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit-ews: commit-queue-
Patch
webkit-ews: commit-queue-
Patch sam: review-

Michael Pruett
Reported 2013-01-04 08:40:15 PST
Add support for setting IndexedDB database path in WK2.
Attachments
Patch (25.41 KB, patch)
2013-01-04 08:50 PST, Michael Pruett 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (25.64 KB, patch)
2013-01-04 09:12 PST, Michael Pruett 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (25.60 KB, patch)
2013-01-04 09:33 PST, Michael Pruett 		sam: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michael Pruett
Comment 1 2013-01-04 08:50:45 PST
Created attachment 181306 [details] Patch
WebKit Review Bot
Comment 2 2013-01-04 08:53:24 PST
Attachment 181306 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/WebCoreSupport/WebIndexedDBDatabaseManager.cpp:32: You should add a blank line after implementation file's own header. [build/include_order] [4] Source/WebKit2/WebProcess/WebCoreSupport/WebIndexedDBDatabaseManager.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2013-01-04 08:56:08 PST
Comment on attachment 181306 [details] Patch Attachment 181306 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15701196
Michael Pruett
Comment 4 2013-01-04 09:12:08 PST
Created attachment 181310 [details] Patch
Early Warning System Bot
Comment 5 2013-01-04 09:26:58 PST
Comment on attachment 181310 [details] Patch Attachment 181310 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15710219
Michael Pruett
Comment 6 2013-01-04 09:33:23 PST
Created attachment 181318 [details] Patch
Gyuyoung Kim
Comment 7 2013-01-05 05:31:58 PST
Comment on attachment 181318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181318&action=review > Source/WebKit2/ChangeLog:7 > + Missing patch description.
Sam Weinig
Comment 8 2013-01-07 12:47:59 PST
Comment on attachment 181318 [details] Patch We already have a databaseDirectory, I really don't want another.
Note You need to log in before you can comment on or make changes to this bug.