Bug 106082

Summary: [GTK][Qt] Make compositing messages async again
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kenneth, mrobinson, webkit.review.bot
Priority: P2 Keywords: Gtk, Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2013-01-04 04:04:48 PST
In r138544 SetComposition, ConfirmComposition and CancelComposition messages were made synchronous to update the WebPageProxy editor state. The member is updated but the API layer is not notified, though. So, I wonder whether we could make them async again and use EditorStateChanged message to asynchronously update the WebPageProxy editor state which properly notifies the API layer too.
Attachments
Patch (7.93 KB, patch)
2013-01-04 04:06 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-01-04 04:06:38 PST
Created attachment 181287 [details] Patch
Simon Hausmann
Comment 2 2013-01-04 04:35:10 PST
Comment on attachment 181287 [details] Patch The composition messages from the UI process to the Web process must be async for sure. Synchronous messages from WebProcess to the UI process are okay(ish), but the other way around is a wonderful source of crashes because they still allow for the processing of other sync messages, so they aren't fully blocking. In Qt we made it a policy to not have these, so if we want to share the code this change fixes a regression. If Gtk needs the messages to remain sync, then we have to fork the code.
WebKit Review Bot
Comment 3 2013-01-04 05:25:58 PST
Comment on attachment 181287 [details] Patch Clearing flags on attachment: 181287 Committed r138791: <http://trac.webkit.org/changeset/138791>
WebKit Review Bot
Comment 4 2013-01-04 05:26:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.