[WK2] [Gtk] crash when web inspector is attached, and window height is reduced.

• Component: WebKitGTK
• Status: RESOLVED FIXED

[arno.]

Hi,
I display web inspector in MiniBrowser (this requires patch from #106050), attached to the webview.
Then I reduce window size.
When height is small enough, main view height reaches 0, and the browser crashes.
It crashes from a x11 error in RedirectedXCompositeWindow::resize because size.height() is <= 0

[arno.]

Created attachment 181234 [details]
patch proposal: detach inspector when webViewBase height becomes too small

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 181234 [details]
patch proposal: detach inspector when webViewBase height becomes too small

Seems that it would be a bit jarring to turn off the inspector completely if you shrank the window and then made it larger again. Why not just hide the inspector if there isn't enough space?

[arno.]

Created attachment 181242 [details]
patch proposal: updated patch: wrong static_cast

[Carlos Garcia Campos]

Comment on attachment 181242 [details]
patch proposal: updated patch: wrong static_cast

I don't think detaching the inspector is the right fix, here. There are actually two bugs, we shouldn't allocate for the children a size bigger than the parent, and we should make sure the widget allocation is always >= 1 (which is what GTK does in gtk_widget_size_allocate())

[Carlos Garcia Campos]

Created attachment 181299 [details]
A different approach

[Carlos Garcia Campos]

Committed r138803: <http://trac.webkit.org/changeset/138803>