Bug 10602

Summary: Crash in IconDatabase::retainIconForPageURL if icon database path is not writable
Product: WebKit Reporter: ian grant <ian.grant>
Component: WebCore Misc.Assignee: ian grant <ian.grant>
Status: NEW ---    
Severity: Critical CC: beidson, ben, mrowe
Priority: P2 Keywords: InRadar, Regression
Version: 420+   
Hardware: Mac (PowerPC)   
OS: OS X 10.4   
Attachments:
Description Flags
Safari Crash Log none

Description ian grant 2006-08-28 03:43:32 PDT
I'm new to running webkit and I am having problems launching the latest build on a ppc powerbook. I get 'safari has extensions installed' and a warning this may cause problems etc... 

I have removed the input managers that may be called extensions (sogudi etc.). and delete SIMBL directories in ~/Application Support/SIMBL etc. Still no application launch. Subsequent launches display a message like 'webkit had problems launching last time etc...' and fails to launch. I get the same warning about extensions on an intel laptop but have not installed any (I think). Webkit runs fine on the intel though after the initial warning. When I started running webkit - about 2 weeks ago - it ran fine on the PPC.

Mac os 10.4.7 (PPC)
The safari crash log is posted to the URL below: I will also attach it to this bug-report.

http://paste.lisp.org/display/24876
Comment 1 ian grant 2006-08-28 03:44:36 PDT
Created attachment 10269 [details]
Safari Crash Log

Safari Crash Log
Comment 2 Mark Rowe (bdash) 2006-08-28 03:57:54 PDT
The warning about extensions is a symptom of the crash during launch.  It will only appear if you have one or more extension installed, though it doesn't seem to be relevant based on your crash log.

Brady, the crash report indicates that it is failing during bindText16 inside IconDatabase::retainIconForPageURL so it seems likely that you'll be interested in this.

I cannot reproduce this on my Intel or PowerPC machines.
Comment 3 ian grant 2006-08-28 04:44:43 PDT
Fixed - I had used 'Cocktail' http://www.maintain.se/cocktail/ 
to switch 'Do Not Cache Website Icons' preference of Safari on. I switched it off and webkit launched.
Comment 4 Mark Rowe (bdash) 2006-08-28 05:18:03 PDT
Wow.  Cocktail disables the WebKit icon database by doing "chmod 500 ~/Library/Safari/Icons".  I would have thought that "defaults write com.apple.Safari WebIconDatabaseEnabled -bool NO" would have been more sensible, but what would I know.

I can reproduce this crash on both Intel and PowerPC Mac if I do: "chmod u= ~/Library/Safari/Icons".
Comment 5 Brady Eidson 2006-08-28 09:26:51 PDT
This is disturbing.  
T'is why foreign binaries injected into webkit/safari aren't supported...

how'd you figure that out, Mark?

And yes, I will be interested, thanks for letting me know.  We obviously shouldn't crash on missing/inaccessible icon.db

Thanks
Comment 6 Mark Rowe (bdash) 2006-08-28 13:56:30 PDT
I'm not sure I follow the comment about foreign binaries injected into Safari -- Cocktail is a standalone application for twiddling "settings" like that.  I tracked this one down the old-fashioned way -- gdb and ktrace on Cocktail while its changing the setting.
Comment 7 Brady Eidson 2006-08-28 14:13:00 PDT
Nevermind then - I skimmed through and thought that Cocktail was an "extension" that ran inside the app.

Thanks  :)
Comment 8 Brady Eidson 2006-08-29 15:54:19 PDT
<rdar://problem/4707718>
Comment 9 Brady Eidson 2006-08-29 15:56:38 PDT
And now we're getting dupes of this issue -
http://bugzilla.opendarwin.org/show_bug.cgi?id=10630

A relatively simple fix is in the works
Comment 10 Benjamin Morin 2006-08-29 15:57:21 PDT
*** Bug 10630 has been marked as a duplicate of this bug. ***
Comment 11 Brady Eidson 2006-09-06 22:06:23 PDT
This has been fixed as of r16132 - please confirm and close