Bug 106010

Summary: [EFL][WK2] Remove unneeded EwkViewImpl::informLoadCommitted()
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Mikhail Pozdnyakov
Reported 2013-01-03 05:51:42 PST
EwkViewImpl::informLoadCommitted() is invoked from only from PageLoadClientEfl::didCommitLoadForFrame() and it contains only 'm_pageClient->didCommitLoad();' inside. It would be much simpler if PageClient::didCommitLoad() was invoked directly from PageLoadClientEfl. Moreover 'informLoadCommitted' name is misleading, as this function does not inform actually.
Attachments
patch (3.51 KB, patch)
2013-01-03 06:14 PST, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2013-01-03 06:14:19 PST
Created attachment 181168 [details] patch
Chris Dumez
Comment 2 2013-01-03 06:19:46 PST
Comment on attachment 181168 [details] patch Makes sense. LGTM.
WebKit Review Bot
Comment 3 2013-01-04 00:05:47 PST
Comment on attachment 181168 [details] patch Clearing flags on attachment: 181168 Committed r138780: <http://trac.webkit.org/changeset/138780>
WebKit Review Bot
Comment 4 2013-01-04 00:05:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.