Bug 105992

Summary: Use toSize() to convert from Int/FloatPoint to Int/FloatSize
Product: WebKit Reporter: Steve Block <steveblock>
Component: New BugsAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, ojan.autocc, simon.fraser, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Steve Block
Reported 2013-01-02 20:55:05 PST
Use toSize() to convert from Int/FloatPoint to Int/FloatSize
Attachments
Patch (7.52 KB, patch)
2013-01-02 20:58 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (8.87 KB, patch)
2013-01-06 21:23 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (8.89 KB, patch)
2013-01-07 22:01 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (8.92 KB, patch)
2013-01-07 22:41 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2013-01-02 20:58:00 PST
Created attachment 181142 [details] Patch
Steve Block
Comment 2 2013-01-02 22:11:48 PST
Using toSize() seems easier to read than using operator- with a zero Int/FloatPoint.
Steve Block
Comment 3 2013-01-06 21:23:13 PST
Created attachment 181475 [details] Patch
Kentaro Hara
Comment 4 2013-01-07 21:48:57 PST
Comment on attachment 181475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181475&action=review > Source/WebCore/platform/graphics/FloatPoint.h:266 > +inline FloatSize toSize(const FloatPoint& a) Maybe toFloatSize() is a better name? Other method names around here clarify Int or Float.
Steve Block
Comment 5 2013-01-07 22:00:03 PST
Comment on attachment 181475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181475&action=review >> Source/WebCore/platform/graphics/FloatPoint.h:266 >> +inline FloatSize toSize(const FloatPoint& a) > > Maybe toFloatSize() is a better name? Other method names around here clarify Int or Float. Sure. I'll rename IntSize toSize(const IntPoint&) in a follow-up patch.
Kentaro Hara
Comment 6 2013-01-07 22:01:11 PST
Comment on attachment 181475 [details] Patch OK, please fix it in a follow-up patch.
Steve Block
Comment 7 2013-01-07 22:01:21 PST
Created attachment 181639 [details] Patch
Steve Block
Comment 8 2013-01-07 22:41:42 PST
Created attachment 181647 [details] Patch
Steve Block
Comment 9 2013-01-07 22:41:58 PST
rebased
WebKit Review Bot
Comment 10 2013-01-07 23:48:19 PST
Comment on attachment 181647 [details] Patch Clearing flags on attachment: 181647 Committed r139037: <http://trac.webkit.org/changeset/139037>
WebKit Review Bot
Comment 11 2013-01-07 23:48:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.