Summary: | [Mac] Some inspector tests intermittently assert in InspectorOverlay::paint | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Major | CC: | apavlov, jberlin, jer.noble, joepeck, keishi, loislo, pfeldman, pmuellr, simon.fraser, thorton, timothy, vsevik, web-inspector-bugs, webkit-bug-importer, yurys | ||||
Priority: | P1 | Keywords: | InRadar, LayoutTestFailure | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-01-02 19:21:32 PST
Added a flaky crash expectation in http://trac.webkit.org/changeset/138694. Another one: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r138805%20(4304)/results.html This bug is preventing us from making debug bots green. This is happening on Lion Debug WK2 tests as well: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r148713%20(8976)/inspector/debugger/script-extract-outline-crash-log.txt I am going to wait to see that particular test again before marking as flakey. This test is now consistently flakey on Lion & Mountain Lion WK1 & WK2 bots. Added flakiness expectations for all Mac platforms in http://trac.webkit.org/changeset/154189. I tried to track down where the layout is being invalidated and not performed, but failed (the build with logging was far, far too slow, and I couldn't reproduce the problem anymore). I don't see any particular reason why we can't just do layout in InspectorOverlay::paint if it's stale. Anyone? Created attachment 209218 [details]
Patch
Comment on attachment 209218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209218&action=review r=me > Source/WebCore/inspector/InspectorOverlay.cpp:213 > + view->updateLayoutAndStyleIfNeededRecursive(); > ASSERT(!view->needsLayout()); Seems like you can remove the ASSERT now. |