Bug 105955

Summary: [Chromium] Add Platform/chromium to include_dirs
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2013-01-02 15:12:26 PST
[Chromium] Add Platform/chromium to include_dirs
Attachments
Patch (2.50 KB, patch)
2013-01-02 15:15 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2013-01-02 15:30 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2013-01-02 15:15:41 PST
Created attachment 181077 [details] Patch
James Robinson
Comment 2 2013-01-02 15:20:40 PST
Comment on attachment 181077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181077&action=review Close! > Source/WebKit/chromium/WebKit.gyp:702 > + 'include_dirs': [ > + '../../Platform/chromium/', > + ], I don't think you need to add this in the 'component=="shared_library"' conditional since it applies equally to component and non-component builds. > Source/WebKit/chromium/WebKit.gyp:777 > + '../../Platform/chromium/', similarly, this include path doesn't depend on the value of 'inside_chromium_build' so it shouldn't be inside a conditional block. could you add a new 'direct_dependent_settings' block outside the conditionals?
Mark Pilgrim (Google)
Comment 3 2013-01-02 15:30:17 PST
Created attachment 181084 [details] Patch
Mark Pilgrim (Google)
Comment 4 2013-01-02 15:30:34 PST
Comment on attachment 181084 [details] Patch Feedback addressed.
WebKit Review Bot
Comment 5 2013-01-02 16:10:08 PST
Comment on attachment 181084 [details] Patch Clearing flags on attachment: 181084 Committed r138673: <http://trac.webkit.org/changeset/138673>
WebKit Review Bot
Comment 6 2013-01-02 16:10:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.