Bug 105954
| Summary: | [WK2] http/tests/navigation/reload-subframe-object.html fails | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, cgarcia, Hironori.Fujii, sam |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
http/tests/navigation/reload-subframe-object.html has been failing on Mac WebKit2 bots:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showExpectations=true&tests=http%2Ftests%2Fnavigation%2Freload-subframe-object.html
--- /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/http/tests/navigation/reload-subframe-object-expected.txt
+++ /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/http/tests/navigation/reload-subframe-object-actual.txt
@@ -1,6 +1 @@
-
---------
-Frame: '<!--framePath //<!--frame0-->-->'
---------
-Pass
It appears that WTR isn’t waiting for subframes to load. There’s a line in platform/wk2/TestExpectations that says "# testRunner.queueLoad should consider given target." but I don’t know what that means.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Added a test expectation in http://trac.webkit.org/changeset/138659.
Carlos Garcia Campos
This is no longer mac specific, it has started to happen in GTK+ now that we have improved our MIME type registry.
Fujii Hironori
(In reply to Ryosuke Niwa from comment #0)
> There’s a line in
> platform/wk2/TestExpectations that says "# testRunner.queueLoad should
> consider given target." but I don’t know what that means.
testRunner.queueLoad takes the second arguemnt 'target'. But, WebKitTestRunner doesn't support it yet.
https://github.com/WebKit/WebKit/blob/3d4708a97aa0fa3ab228eba63a8dbd1b30ad8f7b/Tools/WebKitTestRunner/WorkQueueManager.cpp#L144
However, this is irrevant for this test case because it doesn't use the second arguemnt.
Fujii Hironori
DRT is transiting to ReadyToDump state after all WorkQueue items are completed.
https://github.com/WebKit/WebKit/blob/3d4708a97aa0fa3ab228eba63a8dbd1b30ad8f7b/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm#L171-L172
However, WTR is doing dump immeadeatly after all WorkQueue items are completed.
https://github.com/WebKit/WebKit/blob/3d4708a97aa0fa3ab228eba63a8dbd1b30ad8f7b/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp#L462-L463