Summary: | [WK2] Rename SetFrameInViewSourceMode to SetMainFrameInViewSourceMode | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, gustavo, mrobinson, sam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-12-31 06:04:44 PST
Created attachment 180972 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Attachment 180972 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/WebPage/WebPage.h:794: The parameter name "inViewSourceMode" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit2/UIProcess/WebPageProxy.h:775: The parameter name "inViewSourceMode" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 180973 [details]
Fix style issues
Committed r138622: <http://trac.webkit.org/changeset/138622> |