Bug 105856 – Web Inspector: Workspace should support several projects and should not have temporary UISourceCodes.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Vsevolod Vlasov]

Workspace now supports several projects with the networkProject being a main one.
Replaced temporary UISourceCodes with specific projects (debugger and liveedit).
The concept of workspace reset on navigation is now replaced with project reset concept instead.
Introduced snippets project (that is not reset on navigation).
Script mappings are now reset on GlobalObjectCleared event.

[Vsevolod Vlasov]

Created attachment 180933 [details]
Patch

[Pavel Feldman]

Comment on attachment 180933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180933&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:239
> +                    this._breakpoints.remove(breakpoint);

This might be a bit more expensive than maintaining buckets for breakpoints.

[Pavel Feldman]

Comment on attachment 180933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180933&action=review

> Source/WebCore/inspector/front-end/Workspace.js:45
> +        WebInspector.cssModel.resetSourceMappings();

This does not sound right - controller should not depend on providers.

> Source/WebCore/inspector/front-end/inspector.js:434
> +    this.networkWorkspaceProvider = new WebInspector.NetworkWorkspaceProvider();

Move this somewhere.

[Vsevolod Vlasov]

Created attachment 181905 [details]
Patch

[Build Bot]

Comment on attachment 181905 [details]
Patch

Attachment 181905 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15755629

New failing tests:
inspector/debugger/watch-expressions-preserve-expansion.html

[Vsevolod Vlasov]

Created attachment 182302 [details]
Patch

[Build Bot]

Comment on attachment 182302 [details]
Patch

Attachment 182302 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15812184

New failing tests:
inspector/debugger/watch-expressions-preserve-expansion.html

[WebKit Review Bot]

Comment on attachment 182302 [details]
Patch

Attachment 182302 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15811243

New failing tests:
inspector/debugger/live-edit-breakpoints.html

[Pavel Feldman]

Comment on attachment 182302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182302&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:230
> +        var project = event.data;

Cast annotation?

> Source/WebCore/inspector/front-end/CSSStyleModel.js:485
> +    _inspectedURLChanged: function(event)

This little refactoring looks like a separate change.

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:622
> +        if (projectName === WebInspector.projectNames.Debugger || projectName === WebInspector.projectNames.LiveEdit)

project.isServiceProject()

> Source/WebCore/inspector/front-end/LiveEditSupport.js:157
> +        this.addFile(uniqueURI, url, contentProvider, isEditable);

I would do that in the call site.

[WebKit Review Bot]

Comment on attachment 182302 [details]
Patch

Attachment 182302 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15802371

New failing tests:
inspector/debugger/live-edit-breakpoints.html

[Vsevolod Vlasov]

Created attachment 182346 [details]
Patch for landing

[Vsevolod Vlasov]

Committed r139454: <http://trac.webkit.org/changeset/139454>