Bug 105854

Summary: Web Inspector: [Timeline] cpu bar popover shows wrong duration / cpu time.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, caseq, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Eugene Klyuchnikov
Reported 2012-12-29 02:56:47 PST
Problem: CPU task indexes are already incremented before written to data structure.
Attachments
Patch (2.12 KB, patch)
2012-12-29 02:58 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (1.80 KB, patch)
2012-12-29 03:23 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2012-12-29 02:58:21 PST
Created attachment 180928 [details] Patch
Andrey Kosyakov
Comment 2 2012-12-29 03:16:36 PST
Comment on attachment 180928 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180928&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:955 > + lastElement._tasksInfo.lastTaskIndex = taskIndex - 1; just make it a for() loop and these -1s will go away.
Eugene Klyuchnikov
Comment 3 2012-12-29 03:20:39 PST
Comment on attachment 180928 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180928&action=review >> Source/WebCore/inspector/front-end/TimelinePanel.js:955 >> + lastElement._tasksInfo.lastTaskIndex = taskIndex - 1; > > just make it a for() loop and these -1s will go away. Done
Eugene Klyuchnikov
Comment 4 2012-12-29 03:23:02 PST
Created attachment 180929 [details] Patch
Andrey Kosyakov
Comment 5 2012-12-29 04:10:23 PST
Comment on attachment 180929 [details] Patch LGTM
WebKit Review Bot
Comment 6 2012-12-29 04:42:19 PST
Comment on attachment 180929 [details] Patch Clearing flags on attachment: 180929 Committed r138564: <http://trac.webkit.org/changeset/138564>
WebKit Review Bot
Comment 7 2012-12-29 04:42:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.