Bug 105849

Summary: Web Inspector: DataGrid refactoring: make cell editing more generic.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Eugene Klyuchnikov
Reported 2012-12-28 22:28:53 PST
Editing feature has been added to DataGrid to edit localStorage. Column numbers (0 and 1) are hardcoded. This patch makes column editing feature more generic: remove hardcoded colums, take "editable" column property into account. This patch is a prerequisite for cookie editing.
Attachments
Patch (18.53 KB, patch)
2012-12-28 23:39 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2012-12-28 23:39:13 PST
Created attachment 180920 [details] Patch
WebKit Review Bot
Comment 2 2013-01-10 21:50:48 PST
Comment on attachment 180920 [details] Patch Clearing flags on attachment: 180920 Committed r139404: <http://trac.webkit.org/changeset/139404>
WebKit Review Bot
Comment 3 2013-01-10 21:50:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.