Bug 105827

Summary: Web Inspector: debugger should step into event handler on event dispatch
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, haraken, japhet, keishi, loislo, pfeldman, philn, pmuellr, vsevik, web-inspector-bugs, webkit-ews, webkit.review.bot, xan.lopez, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Test case
none
Patch
none
Patch with comments addressed
none
Patch
pfeldman: review+, webkit-ews: commit-queue-
Patch with fix for JSC none

Description Yury Semikhatsky 2012-12-28 04:47:34 PST 
Created attachment 180863 [details]
Test case

Upstreaming Chromium bug: http://crbug.com/164010

What steps will reproduce the problem?
1. Load the attached page in chrome
2. Set a breakpoint inside the button click handler
3. Click the button
4. Step into the dispatchEvent call

What is the expected result?
When stepping into the dispatchEvent call, the debugger enters the div's 'foo' event handler.

What happens instead?
The debugger skips over the dispatchEvent call.
Comment 1 Yury Semikhatsky 2012-12-28 05:04:16 PST 
Created attachment 180864 [details]
Patch
Comment 2 Pavel Feldman 2012-12-28 05:18:14 PST 
Comment on attachment 180864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180864&action=review

> Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:111
> +    m_pauseInNextEventListener = false;

You should also clean it up upon existing from the message loop entry.
Comment 3 Yury Semikhatsky 2012-12-28 05:42:13 PST 
Created attachment 180866 [details]
Patch with comments addressed
Comment 4 Yury Semikhatsky 2012-12-28 06:20:38 PST 
Created attachment 180869 [details]
Patch
Comment 5 Early Warning System Bot 2012-12-28 06:24:41 PST 
Comment on attachment 180869 [details]
Patch

Attachment 180869 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15545849
Comment 6 Build Bot 2012-12-28 06:25:25 PST 
Comment on attachment 180869 [details]
Patch

Attachment 180869 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15549810
Comment 7 EFL EWS Bot 2012-12-28 06:25:31 PST 
Comment on attachment 180869 [details]
Patch

Attachment 180869 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15572419
Comment 8 Early Warning System Bot 2012-12-28 06:27:04 PST 
Comment on attachment 180869 [details]
Patch

Attachment 180869 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15551777
Comment 9 Yury Semikhatsky 2012-12-28 06:33:12 PST 
Created attachment 180870 [details]
Patch with fix for JSC
Comment 10 Yury Semikhatsky 2012-12-28 06:43:34 PST 
Committed r138534: <http://trac.webkit.org/changeset/138534>