Bug 105783

Summary: Remove extra space in CustomFilterRenderer.h
Product: WebKit Reporter: Qiankun Miao <qiankun.miao>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, haraken, qiankun.miao, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Qiankun Miao
Reported 2012-12-26 21:56:19 PST
Remove extra space in CustomFilterRenderer.h
Attachments
Patch (1.43 KB, patch)
2012-12-26 21:57 PST, Qiankun Miao 		no flags
DetailsFormatted DiffDiff
Patch (1.40 KB, patch)
2012-12-27 17:44 PST, Qiankun Miao 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Qiankun Miao
Comment 1 2012-12-26 21:57:35 PST
Created attachment 180775 [details] Patch
Sam Weinig
Comment 2 2012-12-27 09:26:48 PST
This seems like an unnecessary change. This can be fixed the next time that line is touched.
Darin Adler
Comment 3 2012-12-27 09:48:53 PST
Comment on attachment 180775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180775&action=review OK. Normally we wouldn’t do a check-in just to remove one trailing space, but I see no harm in it. > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Can’t land a patch with a line like this.
Qiankun Miao
Comment 4 2012-12-27 17:44:20 PST
Reopening to attach new patch.
Qiankun Miao
Comment 5 2012-12-27 17:44:25 PST
Created attachment 180833 [details] Patch
Kentaro Hara
Comment 6 2012-12-28 00:05:09 PST
(In reply to comment #2) > This seems like an unnecessary change. This can be fixed the next time that line is touched. Sam: As you mentioned, conventionally WebKit doesn't accept style-only-fix patches (in order not to mess up histories). But do we have any coding guideline about that? (When I was asked about that last time, I couldn't find the policy anywhere.)
Sam Weinig
Comment 7 2012-12-28 08:34:23 PST
(In reply to comment #6) > (In reply to comment #2) > > This seems like an unnecessary change. This can be fixed the next time that line is touched. > > Sam: As you mentioned, conventionally WebKit doesn't accept style-only-fix patches (in order not to mess up histories). But do we have any coding guideline about that? (When I was asked about that last time, I couldn't find the policy anywhere.) I don't think there is a policy (and I am not sure how much weight I give the messing up histories argument, you can always go back further), nor do I think we really need or want one. We actually have a history of doing style clean up to make sure things stay spiffy. In this case, my gripe was with how marginal the change was.
Dean Jackson
Comment 8 2013-01-15 13:06:15 PST
Comment on attachment 180833 [details] Patch As Darin said, no harm.
WebKit Review Bot
Comment 9 2013-01-15 22:47:57 PST
Comment on attachment 180833 [details] Patch Clearing flags on attachment: 180833 Committed r139837: <http://trac.webkit.org/changeset/139837>
WebKit Review Bot
Comment 10 2013-01-15 22:48:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.