| Summary: | Remove extra space in CustomFilterRenderer.h | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Qiankun Miao <qiankun.miao> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, haraken, qiankun.miao, sam, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Qiankun Miao
2012-12-26 21:56:19 PST
Created attachment 180775 [details]
Patch
This seems like an unnecessary change. This can be fixed the next time that line is touched. Comment on attachment 180775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180775&action=review OK. Normally we wouldn’t do a check-in just to remove one trailing space, but I see no harm in it. > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Can’t land a patch with a line like this. Reopening to attach new patch. Created attachment 180833 [details]
Patch
(In reply to comment #2) > This seems like an unnecessary change. This can be fixed the next time that line is touched. Sam: As you mentioned, conventionally WebKit doesn't accept style-only-fix patches (in order not to mess up histories). But do we have any coding guideline about that? (When I was asked about that last time, I couldn't find the policy anywhere.) (In reply to comment #6) > (In reply to comment #2) > > This seems like an unnecessary change. This can be fixed the next time that line is touched. > > Sam: As you mentioned, conventionally WebKit doesn't accept style-only-fix patches (in order not to mess up histories). But do we have any coding guideline about that? (When I was asked about that last time, I couldn't find the policy anywhere.) I don't think there is a policy (and I am not sure how much weight I give the messing up histories argument, you can always go back further), nor do I think we really need or want one. We actually have a history of doing style clean up to make sure things stay spiffy. In this case, my gripe was with how marginal the change was. Comment on attachment 180833 [details]
Patch
As Darin said, no harm.
Comment on attachment 180833 [details] Patch Clearing flags on attachment: 180833 Committed r139837: <http://trac.webkit.org/changeset/139837> All reviewed patches have been landed. Closing bug. |