Bug 105767

Summary: Build fix for WinCE after r137709
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: JavaScriptCoreAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, d-r, fmalita, fpizlo, mjs, ojan.autocc, pdr, schenney, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 104890    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2012-12-26 05:52:12 PST
Build fix for WinCE after r137709
Attachments
Patch (9.10 KB, patch)
2012-12-26 06:08 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (4.54 KB, patch)
2013-01-27 13:38 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-12-26 06:08:40 PST
Created attachment 180745 [details] Patch
Filip Pizlo
Comment 2 2012-12-27 06:54:54 PST
Comment on attachment 180745 [details] Patch Really, this is necessary? That kind of defeats the purpose of trying to rationalize how binarySearch works. :-( Is it absolutely clear that the WinCE compiler (presumably some variant of VS?) needs this much help, and is this far from C++ compliance?
Benjamin Poulain
Comment 3 2012-12-27 07:25:07 PST
I am also curious to know what makes this template different? Type resolution seems to work everywhere else.
Maciej Stachowiak
Comment 4 2013-01-18 23:03:25 PST
What does the WinCE compiler complain about exactly? Is there another compiler that can be used?
Patrick R. Gansterer
Comment 5 2013-01-27 13:38:09 PST
Created attachment 184923 [details] Patch (In reply to comment #2) > Really, this is necessary? It seems that I found a better solution for this in the new patch. (In reply to comment #4) > What does the WinCE compiler complain about exactly? could not deduce template argument for 'overloaded function type' from 'overloaded function type' > Is there another compiler that can be used? No, this is the only compiler which produces production code for WinCE.
Patrick R. Gansterer
Comment 6 2013-01-29 08:21:20 PST
ping?
Patrick R. Gansterer
Comment 7 2013-02-01 06:15:07 PST
Committed r141586: <http://trac.webkit.org/changeset/141586>
Eric Seidel (no email)
Comment 8 2013-03-01 02:51:18 PST
Comment on attachment 184923 [details] Patch Cleared review? from attachment 184923 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.