Bug 10576

Summary: Disallow copy from new password fields
Product: WebKit Reporter: Adele Peterson <adele>
Component: FormsAssignee: Adele Peterson <adele>
Status: RESOLVED FIXED    
Severity: Normal CC: justin.garcia
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 6990    
Attachments:
Description Flags
patch
none
patch w/ edited changelog adele: review+

Adele Peterson
Reported 2006-08-25 17:44:06 PDT
Disallow copy from new password fields
Attachments
patch (11.24 KB, patch)
2006-08-29 17:16 PDT, Adele Peterson 		no flags
DetailsFormatted DiffDiff
patch w/ edited changelog (11.28 KB, patch)
2006-08-29 17:20 PDT, Adele Peterson 		adele: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adele Peterson
Comment 1 2006-08-29 17:16:07 PDT
Created attachment 10308 [details] patch
Adele Peterson
Comment 2 2006-08-29 17:20:01 PDT
Created attachment 10309 [details] patch w/ edited changelog
Darin Adler
Comment 3 2006-08-30 10:52:34 PDT
Comment on attachment 10309 [details] patch w/ edited changelog I don't like the idea of putting function "isPasswordField" in the base Node class. In Frame::mayCopy, you can check if something is an input element by checking hasTagName(inputTag) and then cast and call a function on HTMLInputElement. Otherwise, this patch looks great.
Adele Peterson
Comment 4 2006-08-30 11:14:58 PDT
Comment on attachment 10309 [details] patch w/ edited changelog Darin and I talked about this, and I'm addressing this by removing isPasswordField.
Adele Peterson
Comment 5 2006-08-30 11:25:59 PDT
Committed revision 16116.
Note You need to log in before you can comment on or make changes to this bug.