[TexMap] A Minor optimization of GraphicsLayerTransform.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Dongseong Hwang]

Don't combine transforms if GraphicsLayerTransform isn't changed actually.

[Dongseong Hwang]

Created attachment 180733 [details]
Patch

[Noam Rosenthal]

Comment on attachment 180733 [details]
Patch

This is redundant; We already perform those checks in GraphicsLayerTextureMapper.

[Dongseong Hwang]

(In reply to comment #2)
> (From update of attachment 180733 [details])
> This is redundant; We already perform those checks in GraphicsLayerTextureMapper.

But TextureMapperLayer::flushCompositingStateForThisLayerOnly can change GraphicsLayerTransform every flush.

Furthermore, animations can call setAnimatedTransform(const TransformationMatrix& matrix) with the same matrix.

[Noam Rosenthal]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 180733 [details] [details])
> > This is redundant; We already perform those checks in GraphicsLayerTextureMapper.
> 
> But TextureMapperLayer::flushCompositingStateForThisLayerOnly can change GraphicsLayerTransform every flush.
> 
> Furthermore, animations can call setAnimatedTransform(const TransformationMatrix& matrix) with the same matrix.

OK, you should describe in the changelog what use cases this actually optimizes.

[Dongseong Hwang]

Created attachment 180764 [details]
Patch

[Dongseong Hwang]

(In reply to comment #4)
> OK, you should describe in the changelog what use cases this actually optimizes.

Absolutely! I did.

[Noam Rosenthal]

Comment on attachment 180764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180764&action=review

> Source/WebCore/ChangeLog:11
> +        Don't combine transforms if GraphicsLayerTransform isn't changed actually.
> +
> +        Now this patch optimizes flushCompositingStateForThisLayerOnly() and
> +        setAnimatedTransform() in TextureMapperLayer.

Only multiply the transformation matrices if the paramaters are actually changed.

This optimizes the code path called from flushCompositingStateForThisLayerOnly(), and potentially setAnimatedTransform().

[Dongseong Hwang]

Created attachment 180765 [details]
Patch

[Dongseong Hwang]

(In reply to comment #7)
> Only multiply the transformation matrices if the paramaters are actually changed.
> 
> This optimizes the code path called from flushCompositingStateForThisLayerOnly(), and potentially setAnimatedTransform().

I don't think it is not natural for you to do favor to me. Thank you very much!

[WebKit Review Bot]

Comment on attachment 180765 [details]
Patch

Clearing flags on attachment: 180765

Committed r138487: <http://trac.webkit.org/changeset/138487>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.