Bug 105709

Summary: Reduce the number of includes in WebProcess.h
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, kling, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+, webkit-ews: commit-queue-

Sam Weinig
Reported 2012-12-23 23:10:57 PST
Reduce the number of includes in WebProcess.h
Attachments
Patch (24.17 KB, patch)
2012-12-23 23:11 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (24.10 KB, patch)
2012-12-24 11:10 PST, Sam Weinig 		mitz: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-12-23 23:11:54 PST
Created attachment 180647 [details] Patch
WebKit Review Bot
Comment 2 2012-12-23 23:14:52 PST
Attachment 180647 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/WebProcess.h:66: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2012-12-23 23:17:01 PST
Comment on attachment 180647 [details] Patch Attachment 180647 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15495356
Sam Weinig
Comment 4 2012-12-24 11:10:08 PST
Created attachment 180683 [details] Patch
WebKit Review Bot
Comment 5 2012-12-24 11:13:58 PST
Attachment 180683 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/WebProcess.h:66: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/WebProcess/WebProcess.h:188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 6 2012-12-24 11:17:04 PST
Comment on attachment 180683 [details] Patch Attachment 180683 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15493582
Sam Weinig
Comment 7 2012-12-25 17:38:16 PST
Committed r138466: <http://trac.webkit.org/changeset/138466>
Note You need to log in before you can comment on or make changes to this bug.