Bug 105683

Summary: [Qt] Remove misspelled ENABLE(SPEECH_INPUT) guard
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, allan.jensen, cmarcelo, hausmann, kbalazs, menard, ossy, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed change none

Laszlo Gombos
Reported 2012-12-22 21:43:44 PST
ENABLE(SPEECH_INPUT) is only used in one Qt specific file - ./WebKit2/WebProcess/qt/WebProcessQt.cpp:#if ENABLE(SPEECH_INPUT). The macros should be likely spelled ENABLE(INPUT_SPEECH) instead.
Attachments
proposed change (1.45 KB, patch)
2013-01-25 12:36 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2013-01-25 12:36:24 PST
Created attachment 184795 [details] proposed change After a second look I think it is better to remove the guard instead of renaming it.
WebKit Review Bot
Comment 2 2013-01-29 03:33:44 PST
Comment on attachment 184795 [details] proposed change Clearing flags on attachment: 184795 Committed r141092: <http://trac.webkit.org/changeset/141092>
WebKit Review Bot
Comment 3 2013-01-29 03:33:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.