Bug 105680
| Summary: | [BlackBerry] Remove ENABLE_BLACKBERRY_CREDENTIAL_PERSIST | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> |
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mxie, rwlbuis |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Laszlo Gombos
ENABLE macros are usually not port specific - this is one of the few exceptions where the macro is only used by one port.
It seems that the macro has been turned on since 05/06/12 (r116241). Is there a need going forward to disable this flag ? Would it be possible to remove this define ?
Each build time configuration adds a maintenance burden to the project, so in general the less ENABLE_XX macros we have the easier it is to maintain the project. This is by no means urgent, as the name of the macro makes it obvious that this is a macro for BlackBerry port only.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Rob Buis
This one is still in use in http://trac.webkit.org/browser/trunk/Source/WebKit/blackberry/Api/WebPage.cppL2210, so we can't remove it AFAICS. Can you suggest an alternative?
Laszlo Gombos
(In reply to comment #1)
> This one is still in use in http://trac.webkit.org/browser/trunk/Source/WebKit/blackberry/Api/WebPage.cppL2210, so we can't remove it AFAICS. Can you suggest an alternative?
Thanks Rob. I can see that the flag is there but it seems to be always enabled.
Is there a need to have it conditional (and support the possibility of turning the flag off)? If there is still a need, than I think all is fine and we should close this bug.
Laszlo Gombos
Fixed by bug 126715.