Bug 105653

Summary: Web Inspector: Update CodeMirror to stable
Product: WebKit Reporter: Jan Keromnes <janx>
Component: Web Inspector (Deprecated)Assignee: Jan Keromnes <janx>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Jan Keromnes
Reported 2012-12-21 12:49:00 PST
CodeMirror's v3 branch has matured and is now the master branch. Updating to stable would fix several minor issues, including throw scrolling on mac: https://github.com/marijnh/CodeMirror/issues/728
Attachments
Patch (153.69 KB, patch)
2012-12-21 15:06 PST, Jan Keromnes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Keromnes
Comment 1 2012-12-21 15:06:18 PST
Created attachment 180562 [details] Patch
Jan Keromnes
Comment 2 2012-12-21 15:07:48 PST
+pfeldman can you have a look at the scrolling behavior? The problems you spotted earlier should be gone now.
Pavel Feldman
Comment 3 2012-12-21 23:10:40 PST
Comment on attachment 180562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180562&action=review > Source/WebCore/inspector/front-end/cm/codemirror.css:156 > + /* Hack to make IE7 behave */ Seriously? :)
WebKit Review Bot
Comment 4 2012-12-21 23:35:55 PST
Comment on attachment 180562 [details] Patch Clearing flags on attachment: 180562 Committed r138410: <http://trac.webkit.org/changeset/138410>
WebKit Review Bot
Comment 5 2012-12-21 23:35:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.