Bug 105616
| Summary: | Spell checking tests don't seem work in WebKit2 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, ben_schwartz, enrica, g.czajkowski, jiapu.mail, megan_gardner, mitz, mmaxfield, rniwa, thorton, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 125690 | ||
| Bug Blocks: | 187655 | ||
Ryosuke Niwa
It appears that spellcheck / auto correction tests don't work at all in WebKit2. We need to make them working in WebKit2.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Grzegorz Czajkowski
WebKitTestRunner doesn't enable spell checking settings for Mac. I disabled this code as Mac hadn't compiled API to control spell checking - WKTextChecker.h/cpp. See https://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/TestController.cpp#L591
Please omit this comment if Mac enables the spell checking by default.
Alexey Proskuryakov
FWIW, platform/mac/editing/spelling/delete-autocorrected-word-2.html passed for me on Yosemite in WK2.
I did not investigate any further. It could be that this test works now, or that all of them work, or even that this test fails on both WK1 and WK2, and has wring results checked in.
Myles C. Maxfield
My patch in https://bugs.webkit.org/show_bug.cgi?id=190764 adds a new mechanism for making spelling dots be drawn in WK2 tests.
Radar WebKit Bug Importer
<rdar://problem/115844741>