Bug 10561

Summary: Qt doesn't build at the moment.
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Other   
OS: OS X 10.4   
Attachments:
Description Flags
Initial patch
none
Updated patch
none
Updated patch II none

Nikolas Zimmermann
Reported 2006-08-25 04:08:26 PDT
Some fixes regarding EditCommandPtr are needed, the patch changed platform/mac and platform/gdk, but Qt was forgotten :-)
Attachments
Initial patch (1.75 KB, patch)
2006-08-25 04:08 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch (5.11 KB, patch)
2006-08-25 10:55 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch II (4.27 KB, patch)
2006-08-25 11:12 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2006-08-25 04:08:49 PDT
Created attachment 10215 [details] Initial patch
Nikolas Zimmermann
Comment 2 2006-08-25 06:49:10 PDT
Hmpf, there is much more needed to get it build again, the whole Widget/Screen/Page changes have to be done :/ Will take me some hours if I'm back home and able to hack again - stay tuned...
Nikolas Zimmermann
Comment 3 2006-08-25 10:55:27 PDT
Created attachment 10221 [details] Updated patch
Nikolas Zimmermann
Comment 4 2006-08-25 11:12:06 PDT
Created attachment 10223 [details] Updated patch II Made a mistake while preparing the patch, now I double-checked it applies :-)
Adam Roben (:aroben)
Comment 5 2006-08-25 11:15:06 PDT
Comment on attachment 10223 [details] Updated patch II r=me
Adam Roben (:aroben)
Comment 6 2006-08-25 11:17:52 PDT
Comment on attachment 10223 [details] Updated patch II Landed as r16035. Clearing review flag.
Note You need to log in before you can comment on or make changes to this bug.