Bug 10559

Summary: WebKit Qt fixes
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: 420+   
Hardware: Other   
OS: OS X 10.4   
Attachments:
Description Flags
Initial patch
none
Updated patch none

Nikolas Zimmermann
Reported 2006-08-25 02:43:57 PDT
Alexey created a new style cleanup patch, I made it compile (needed some little tweaks) and now it's ready for inclusion :-) We do hope it is really confirming to all style rules in WebKit now!
Attachments
Initial patch (21.63 KB, patch)
2006-08-25 02:52 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch (22.09 KB, patch)
2006-08-25 05:05 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2006-08-25 02:52:29 PDT
Created attachment 10213 [details] Initial patch
Alexey Proskuryakov
Comment 2 2006-08-25 04:36:18 PDT
(In reply to comment #0) > We do hope it is really confirming to all style rules in WebKit now! Heh, I didn't claim that :-P. Actually, I'm now seeing non-conformant code even in the changed chunks, e.g. + SharedTimerQt() : QTimer(), m_timerFunction(0) (we don't explicitly call all initializers). But should be an improvement still...
Nikolas Zimmermann
Comment 3 2006-08-25 05:05:44 PDT
Created attachment 10217 [details] Updated patch Incorporated ap's comment :-)
Adam Roben (:aroben)
Comment 4 2006-08-25 09:35:03 PDT
Comment on attachment 10217 [details] Updated patch r=me
Adam Roben (:aroben)
Comment 5 2006-08-25 09:40:26 PDT
Comment on attachment 10217 [details] Updated patch Landed as r16033. Clearing review flag
Note You need to log in before you can comment on or make changes to this bug.