Bug 105585

Summary: Stop building WebKit2 for Windows
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: jonlee, ossy, rniwa, roger_fong, simon.fraser, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 105668    
Bug Blocks:    
Attachments:
Description Flags
Patch
bweinstein: review+
patch2 sam: review+

Anders Carlsson
Reported 2012-12-20 15:41:42 PST
Stop building WebKit2 for Windows
Attachments
Patch (26.39 KB, patch)
2012-12-20 15:44 PST, Anders Carlsson 		bweinstein: review+
DetailsFormatted DiffDiff
patch2 (518.02 KB, patch)
2013-01-03 12:55 PST, Roger Fong 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-12-20 15:44:13 PST
Created attachment 180426 [details] Patch
Roger Fong
Comment 2 2012-12-20 17:00:26 PST
Do it!
Anders Carlsson
Comment 3 2012-12-20 17:44:31 PST
Committed r138331: <http://trac.webkit.org/changeset/138331>
Ryosuke Niwa
Comment 4 2012-12-21 14:19:42 PST
This might have caused the Win EWS sadness like this one: http://webkit-commit-queue.appspot.com/results/15446597 >WinLauncher.cpp 6>.\WinLauncher.cpp(33) : fatal error C1083: Cannot open include file: 'WebKit/WebKitCOMAPI.h': No such file or directory 6>PrintWebUIDelegate.cpp 6>.\PrintWebUIDelegate.cpp(30) : fatal error C1083: Cannot open include file: 'WebKit/WebKitCOMAPI.h': No such file or directory 6>Generating Code...
Ryosuke Niwa
Comment 5 2012-12-21 15:45:16 PST
The problem is exactly that WebKitCOMAPI.h isn’t copied in include/WebKit directory by WebKitLibPostBuild.cmd script.
Ryosuke Niwa
Comment 6 2012-12-21 16:14:00 PST
I’ve spent some time trying to debug this but I can’t figure it out. I think we need to roll out this change.
WebKit Review Bot
Comment 7 2012-12-21 16:17:12 PST
Re-opened since this is blocked by bug 105668
Roger Fong
Comment 8 2013-01-02 12:09:19 PST
One possible issue: In the ChangeLog, WebKit.vcproj/WebKitDirectX.vsprops: Added. In the patch, this file is not added.
Roger Fong
Comment 9 2013-01-02 12:10:01 PST
And I can't actually load the WebKit vcproj locally at all because of this.
Roger Fong
Comment 10 2013-01-02 12:39:38 PST
(In reply to comment #9) > And I can't actually load the WebKit vcproj locally at all because of this. Also WebKitApple.vsprops
Roger Fong
Comment 11 2013-01-02 15:02:13 PST
Landed fix: http://trac.webkit.org/changeset/138656 after rolling out the roll out
Csaba Osztrogonác
Comment 12 2013-01-03 05:50:26 PST
(In reply to comment #11) > Landed fix: http://trac.webkit.org/changeset/138656 after rolling out the roll out One more fix landed in https://trac.webkit.org/changeset/138706 to make GIT-SVN repositories happy. (for example EWS bots, developers) See https://bugs.webkit.org/show_bug.cgi?id=96934 for details.
Roger Fong
Comment 13 2013-01-03 12:55:54 PST
Created attachment 181207 [details] patch2 We'd like to remove any trace of Windows from the WebKit2 folder. This patch moves the WebKit2exportgenerator project to the WebKit folder and deletes the WebKit2/win folder which just has AppleWindows project files and some image resources.
Roger Fong
Comment 14 2013-01-03 13:00:24 PST
(In reply to comment #13) > Created an attachment (id=181207) [details] > patch2 > > We'd like to remove any trace of Windows from the WebKit2 folder. > This patch moves the WebKit2exportgenerator project to the WebKit folder and deletes the WebKit2/win folder which just has AppleWindows project files and some image resources. Anyone still using those resource files out there? Well, guess I'll find out later.
Jon Lee
Comment 15 2013-01-03 15:10:17 PST
<rdar://problem/12945356>
Roger Fong
Comment 16 2013-01-03 16:02:42 PST
followup patch commited http://trac.webkit.org/changeset/138759
Note You need to log in before you can comment on or make changes to this bug.