Bug 10558

Summary: SVG should have support for <metadata> element
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: EasyFix
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
First attempt none

Eric Seidel (no email)
Reported 2006-08-25 02:33:21 PDT
SVG should have support for <metadata> element This will take about 10 minutes. Most of that will be writing the test case. The test case just needs to check to make sure that the name of the element is SVGMetadataElement. Once this is done we'll be very close to having a complete implementation of the "structure" module for SVG 1.1 FULL.
Attachments
First attempt (21.34 KB, patch)
2006-08-25 06:18 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2006-08-25 06:18:10 PDT
Created attachment 10218 [details] First attempt This should be enough for support of metadata element. Cheers, Rob.
Eric Seidel (no email)
Comment 2 2006-08-26 02:19:15 PDT
Comment on attachment 10218 [details] First attempt I'm not sure I understand this line: + if([meta] == "[object SVGMetadataElement]") { why the extra [ ] around meta? Also, this looks wrong: - JSSVGDocument.h \ Other than that, this patch looks great. r- for the JSSVGDocument.h typo.
Eric Seidel (no email)
Comment 3 2006-08-26 19:35:45 PDT
rob fixed and landed this.
Darin Adler
Comment 4 2006-08-30 14:16:54 PDT
Comment on attachment 10218 [details] First attempt The SVGMetadataElement functions should be inside the WebCore namespace, instead of "using namespace WebCore". There's no need to declare the destructor explicitly.
Note You need to log in before you can comment on or make changes to this bug.