Summary: | Web Inspector: Mac WK1 Inspector can't save/load timeline data | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Adam Roben (:aroben) <aroben> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | apavlov, joepeck, keishi, loislo, pfeldman, pmuellr, sam, timothy, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2012-12-20 09:55:00 PST
Created attachment 180354 [details]
Patch
Created attachment 180355 [details]
Patch
Created attachment 180358 [details]
Patch
Created attachment 180359 [details]
Patch
AFAICT there's no way to save/load timeline data in Safari's Inspector, so I don't think this patch will affect it. And of course this won't affect Safari itself, since this is WK1-only. Comment on attachment 180359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180359&action=review > Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:311 > + if (!forceSaveAs) { You probably want to check for url being a part of m_saveURLs. That way before writing into the FS user will see a file chooser. Comment on attachment 180359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180359&action=review >> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:311 >> + if (!forceSaveAs) { > > You probably want to check for url being a part of m_saveURLs. That way before writing into the FS user will see a file chooser. Ah, good call. I'll do that. Created attachment 180370 [details]
Patch
Created attachment 180398 [details]
Patch
I updated the patch to work correctly when the Inspector is docked. Comment on attachment 180398 [details] Patch Clearing flags on attachment: 180398 Committed r138565: <http://trac.webkit.org/changeset/138565> All reviewed patches have been landed. Closing bug. |