Bug 105500

Summary: Cleanup some captions menu tests
Product: WebKit Reporter: Dean Jackson <dino>
Component: MediaAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Dean Jackson
Reported 2012-12-19 22:59:03 PST
Some of the media captions menu tests can be tidied. For example: - video-controls-captions-trackmenu should use the shared test helper JS library - the tests should dynamically add the video src so that we always catch the 'canplaythrough' event (it sometimes misses)
Attachments
Patch (9.41 KB, patch)
2012-12-19 23:05 PST, Dean Jackson 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-12-19 23:02:16 PST
<rdar://problem/12915971>
Dean Jackson
Comment 2 2012-12-19 23:05:46 PST
Created attachment 180282 [details] Patch
Dean Jackson
Comment 3 2012-12-20 12:13:53 PST
Committed r138283: <http://trac.webkit.org/changeset/138283>
Note You need to log in before you can comment on or make changes to this bug.