Bug 10547

Summary: REGRESSION: Links that should open in a new window open in the same window, while opening another blank window
Product: WebKit Reporter: mitz
Component: Page LoadingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andgarden, candiazoo, dev+webkit, drew, jberry, kenlee333, mjs, Neil, oliver, tyler
Priority: P1 Keywords: EasyFix, InRadar, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: data:text/html,<a%20href="http://www.ibm.com/"%20target="_blank">Click%20me</a>
Attachments:
Description Flags
patch with change log
beidson: review+
newer patch: "the one to land" after Brady's review none

mitz
Reported 2006-08-24 12:06:03 PDT
Click the link in the URL to see the problem: a new window will open in the front, but the linked page will load in the old window.
Attachments
patch with change log (3.02 KB, patch)
2006-09-06 20:33 PDT, Darin Adler 		beidson: review+
DetailsFormatted DiffDiff
newer patch: "the one to land" after Brady's review (4.37 KB, patch)
2006-09-08 10:02 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2006-08-27 20:33:07 PDT
*** Bug 10592 has been marked as a duplicate of this bug. ***
mitz
Comment 2 2006-08-30 03:14:08 PDT
*** Bug 10637 has been marked as a duplicate of this bug. ***
andgarden
Comment 3 2006-08-30 11:57:04 PDT
*** Bug 10639 has been marked as a duplicate of this bug. ***
Matt Lilek
Comment 4 2006-08-30 12:53:09 PDT
As I put in my duplicate (oops), this only happens from the r16007 nightlies and beyond (the r16002 build works as expected).
Neil Lee
Comment 5 2006-09-02 08:24:56 PDT
Confirming - I see the same issue with the latest nightlies.
Mike
Comment 6 2006-09-02 09:29:55 PDT
Not that you need another person confirming it, but I see it too. If you right-click and specify open in new window that works fine.
mitz
Comment 7 2006-09-04 11:59:11 PDT
*** Bug 10730 has been marked as a duplicate of this bug. ***
David Kilzer (:ddkilzer)
Comment 8 2006-09-06 12:12:05 PDT
*** Bug 10757 has been marked as a duplicate of this bug. ***
Darin Adler
Comment 9 2006-09-06 20:29:52 PDT
Very simple coding mistake. I have a fix.
Darin Adler
Comment 10 2006-09-06 20:33:55 PDT
Created attachment 10428 [details] patch with change log
Brady Eidson
Comment 11 2006-09-08 09:55:34 PDT
Comment on attachment 10428 [details] patch with change log I discussed with Darin in IRC that perhaps the "[self release]; return;" could be managed different because it's used multiple times as the "bail out" code... We agreed there should be an "exit method:" label and use gotos instead. Otherwise, r+
Darin Adler
Comment 12 2006-09-08 10:02:11 PDT
Created attachment 10466 [details] newer patch: "the one to land" after Brady's review
Darin Adler
Comment 13 2006-09-10 13:14:58 PDT
Committed revision 16288.
Darin Adler
Comment 14 2006-09-26 11:06:52 PDT
Radar 4701041
Note You need to log in before you can comment on or make changes to this bug.