WebKit should compile on Mac with --shadow-dom

• Component: DOM
• Status: RESOLVED FIXED

[Dominic Mazzoni]

Even though --shadow-dom isn't on by default in the Mac port, sometimes bugs come up that only reproduce when shadow DOM is on, so it'd be nice if we could at least compile with shadow DOM support on all ports.

One example: https://bugs.webkit.org/show_bug.cgi?id=104171

[Hajime Morrita]

Created attachment 181490 [details]
Patch

[Hajime Morrita]

(In reply to comment #0)
> Even though --shadow-dom isn't on by default in the Mac port, sometimes bugs come up that only reproduce when shadow DOM is on, so it'd be nice if we could at least compile with shadow DOM support on all ports.
Yeah, we're trying to make it build-able. But it occasionally fails :-/

[WebKit Review Bot]

Comment on attachment 181490 [details]
Patch

Rejecting attachment 181490 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13282 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
53>At revision 13282.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15742779

[Hajime Morrita]

Created attachment 181602 [details]
Patch for landing

[Hajime Morrita]

Comment on attachment 181602 [details]
Patch for landing

See an error locally. cancelling.

[Hajime Morrita]

Created attachment 181615 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 181615 [details]
Patch for landing

Clearing flags on attachment: 181615

Committed r139027: <http://trac.webkit.org/changeset/139027>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.