Bug 105469

Summary: WebKit should compile on Mac with --shadow-dom
Product: WebKit Reporter: Dominic Mazzoni <dmazzoni>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, dglazkov, ojan.autocc, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Description Dominic Mazzoni 2012-12-19 15:02:20 PST
Even though --shadow-dom isn't on by default in the Mac port, sometimes bugs come up that only reproduce when shadow DOM is on, so it'd be nice if we could at least compile with shadow DOM support on all ports.

One example: https://bugs.webkit.org/show_bug.cgi?id=104171
Comment 1 Hajime Morrita 2013-01-07 03:11:28 PST
Created attachment 181490 [details]
Patch
Comment 2 Hajime Morrita 2013-01-07 03:12:30 PST
(In reply to comment #0)
> Even though --shadow-dom isn't on by default in the Mac port, sometimes bugs come up that only reproduce when shadow DOM is on, so it'd be nice if we could at least compile with shadow DOM support on all ports.
Yeah, we're trying to make it build-able. But it occasionally fails :-/
Comment 3 WebKit Review Bot 2013-01-07 16:25:32 PST
Comment on attachment 181490 [details]
Patch

Rejecting attachment 181490 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13282 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
53>At revision 13282.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15742779
Comment 4 Hajime Morrita 2013-01-07 16:56:41 PST
Created attachment 181602 [details]
Patch for landing
Comment 5 Hajime Morrita 2013-01-07 17:13:13 PST
Comment on attachment 181602 [details]
Patch for landing

See an error locally. cancelling.
Comment 6 Hajime Morrita 2013-01-07 18:04:49 PST
Created attachment 181615 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-01-07 19:02:13 PST
Comment on attachment 181615 [details]
Patch for landing

Clearing flags on attachment: 181615

Committed r139027: <http://trac.webkit.org/changeset/139027>
Comment 8 WebKit Review Bot 2013-01-07 19:02:18 PST
All reviewed patches have been landed.  Closing bug.