Bug 105369

Summary: Remove unnecessary functions from CookiesStrategy
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, gtk-ews, gyuyoung.kim, japhet, rakuco, sam, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
buildbot: commit-queue-
with build fixes beidson: review+

Alexey Proskuryakov
Reported 2012-12-18 16:51:03 PST
Three functions in CookieJar.h are only used from WebKit, so there is no need to pipe them through CookieJar and PlatformStrategies. Strategies are for calling WebKit from WebCore.
Attachments
proposed patch (29.06 KB, patch)
2012-12-18 16:56 PST, Alexey Proskuryakov 		buildbot: commit-queue-
DetailsFormatted DiffDiff
with build fixes (29.83 KB, patch)
2012-12-18 17:07 PST, Alexey Proskuryakov 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-12-18 16:56:32 PST
Created attachment 180061 [details] proposed patch
Build Bot
Comment 2 2012-12-18 17:04:14 PST
Comment on attachment 180061 [details] proposed patch Attachment 180061 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15418352
kov's GTK+ EWS bot
Comment 3 2012-12-18 17:06:16 PST
Comment on attachment 180061 [details] proposed patch Attachment 180061 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15406410
Alexey Proskuryakov
Comment 4 2012-12-18 17:07:59 PST
Created attachment 180063 [details] with build fixes
Brady Eidson
Comment 5 2012-12-18 17:52:25 PST
Comment on attachment 180063 [details] with build fixes View in context: https://bugs.webkit.org/attachment.cgi?id=180063&action=review > Source/WebCore/loader/CookieJar.h:41 > +// Functions in this file take a Document pointer to determine which cookie storage to use. We should merge taht into call sites, and use PlatformCookieJar directly. > + s/taht/that/
Alexey Proskuryakov
Comment 6 2012-12-18 20:24:41 PST
Committed <http://trac.webkit.org/changeset/138109> and <http://trac.webkit.org/changeset/138110>.
Note You need to log in before you can comment on or make changes to this bug.