Bug 105319 – [GStreamer] Buffering ranges are reported incorrectly with GStreamer 1.0

• Component: New Bugs
• Status: RESOLVED FIXED

[Xabier Rodríguez Calvar]

[GStreamer] Buffering ranges are reported incorrectly with GStreamer 1.0

[Xabier Rodríguez Calvar]

Created attachment 179971 [details]
Patch

Fixes problem with reporting the buffering ranges in GStreamer 1.0

[Philippe Normand]

Comment on attachment 179971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179971&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:749
> +#if !defined(GST_API_VERSION_1) && GST_CHECK_VERSION(0, 10, 31)

This code should work for both gst 1.0 and 0.10. If there's a bug when gst 1.0 is enabled it should be fixed :)

[Xabier Rodríguez Calvar]

Created attachment 180357 [details]
Patch

There is a bug in GStreamer 0.10, which is reporting the percentage without using the scale as it should happen. This is fixed in 1.0 so code paths must be different one more time. I am not adding the cq? because I cannot be here to check the bots, thought I would be glad if the patch gets reviewed.

[Philippe Normand]

Comment on attachment 180357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180357&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:85
> +static const gint64 percentMax = GST_FORMAT_PERCENT_MAX;

As this is a global static variable it should probably have a g prefix like the gPlaybinName above, new name would be gPercentMax.

[Xabier Rodríguez Calvar]

Created attachment 180423 [details]
Patch

Fixed contant variable name problem. Still not setting the cq? to wait to be able to watch the bots

[WebKit Review Bot]

Comment on attachment 180423 [details]
Patch

Clearing flags on attachment: 180423

Committed r138364: <http://trac.webkit.org/changeset/138364>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.