Bug 105318

Summary: [GTK] Tests that time out are not considered as failures.
Product: WebKit Reporter: Alberto Garcia <berto>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch #2 none

Alberto Garcia
Reported 2012-12-18 09:48:32 PST
A test should not timeout, and if it does it has to be fixed. See https://bugs.webkit.org/show_bug.cgi?id=49246#c84
Attachments
Patch (1.99 KB, patch)
2012-12-18 09:57 PST, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Patch #2 (1.33 KB, patch)
2012-12-18 16:08 PST, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2012-12-18 09:57:26 PST
Created attachment 179970 [details] Patch The script that parses the GTK API test results only counts lines starting with ERROR as mistakes. This patch also counts lines that end with TIMEOUT. The run-gtk-tests script also counts the number of timeouts when returning the number of tests that fail.
WebKit Review Bot
Comment 2 2012-12-18 10:33:26 PST
Comment on attachment 179970 [details] Patch Clearing flags on attachment: 179970 Committed r138038: <http://trac.webkit.org/changeset/138038>
WebKit Review Bot
Comment 3 2012-12-18 10:33:30 PST
All reviewed patches have been landed. Closing bug.
Alberto Garcia
Comment 4 2012-12-18 16:08:30 PST
Created attachment 180048 [details] Patch #2 There was actually a mistake in the previous patch, this new one fixes it (to be applied on top of the other one). Sorry for the noise.
Carlos Garcia Campos
Comment 5 2012-12-19 02:19:25 PST
Committed r138133: <http://trac.webkit.org/changeset/138133>
Note You need to log in before you can comment on or make changes to this bug.