Bug 105272

Summary:

Web Inspector: [Network] Ordering of cookies displayed is nondeterministic.

Product:

WebKit

Reporter:

Eugene Klyuchnikov <eustas>

Component:

Web Inspector (Deprecated)

Assignee:

Eugene Klyuchnikov <eustas>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Eugene Klyuchnikov

Reported 2012-12-18 02:45:21 PST

Steps to reproduce the problem: 1. In devtools, open the cookies tab for a request. 2. Click on the same request again Result: the ordering of the cookies changes. Original issue: http://code.google.com/p/chromium/issues/detail?id=165572 More detailed observation shows that ordering changes twice: on mouse-down and on mouse-up (completion of click).

Attachments
Patch (3.70 KB, patch) 2012-12-18 02:49 PST, Eugene Klyuchnikov	no flags	Details Formatted Diff Diff
Patch (3.71 KB, patch) 2012-12-18 04:17 PST, Eugene Klyuchnikov	no flags	Details Formatted Diff Diff
Patch (2.77 KB, patch) 2012-12-18 06:40 PST, Eugene Klyuchnikov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eugene Klyuchnikov

Comment 1 2012-12-18 02:49:37 PST

Created attachment 179912 [details] Patch

Alexander Pavlov (apavlov)

Comment 2 2012-12-18 02:58:24 PST

Comment on attachment 179912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179912&action=review > Source/WebCore/ChangeLog:3 > + Web Inspector: Network: Ordering of cookies displayed is nondeterministic. JFYI: We typically denote the affected component in square brackets: "Web Inspector: [Network] Ordering of cookies..." > Source/WebCore/ChangeLog:11 > + * inspector/front-end/CookiesTable.js: By defaulr sort by name. defaulr -> default

Eugene Klyuchnikov

Comment 3 2012-12-18 04:15:08 PST

Comment on attachment 179912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179912&action=review >> Source/WebCore/ChangeLog:3 >> + Web Inspector: Network: Ordering of cookies displayed is nondeterministic. > > JFYI: We typically denote the affected component in square brackets: "Web Inspector: [Network] Ordering of cookies..." Fixed. Thanks. >> Source/WebCore/ChangeLog:11 >> + * inspector/front-end/CookiesTable.js: By defaulr sort by name. > > defaulr -> default fixed.

Eugene Klyuchnikov

Comment 4 2012-12-18 04:17:33 PST

Created attachment 179920 [details] Patch

WebKit Review Bot

Comment 5 2012-12-18 04:58:22 PST

Comment on attachment 179920 [details] Patch Clearing flags on attachment: 179920 Committed r138011: <http://trac.webkit.org/changeset/138011>

WebKit Review Bot

Comment 6 2012-12-18 04:58:25 PST

All reviewed patches have been landed. Closing bug.

Alexander Pavlov (apavlov)

Comment 7 2012-12-18 05:44:01 PST

Reverted r138011 for reason: WebInspector: Broke request selection in the Network panel Committed r138013: <http://trac.webkit.org/changeset/138013>