Bug 105262

Summary: Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
Product: WebKit Reporter: Alice Liu <alice.barraclough>
Component: WebKit APIAssignee: Alice Liu <alice.barraclough>
Status: NEW    
Severity: Normal CC: barraclough, ggaren, mitz, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch andersca: review+

Alice Liu
Reported 2012-12-18 00:25:54 PST
WebFrame could use some SPI for converting DOMNode to a JSValueRef.
Attachments
patch (10.84 KB, patch)
2012-12-18 01:18 PST, Alice Liu 		no flags
DetailsFormatted DiffDiff
patch (10.83 KB, patch)
2012-12-18 01:27 PST, Alice Liu 		no flags
DetailsFormatted DiffDiff
patch (12.98 KB, patch)
2012-12-18 01:44 PST, Alice Liu 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alice Liu
Comment 1 2012-12-18 01:18:03 PST
Created attachment 179898 [details] patch
Alice Liu
Comment 2 2012-12-18 01:27:21 PST
Created attachment 179901 [details] patch
Build Bot
Comment 3 2012-12-18 01:33:04 PST
Comment on attachment 179901 [details] patch Attachment 179901 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15399125
Alice Liu
Comment 4 2012-12-18 01:44:52 PST
Created attachment 179906 [details] patch
Anders Carlsson
Comment 5 2012-12-18 17:47:18 PST
Comment on attachment 179906 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=179906&action=review > Tools/TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm:54 > + RetainPtr<WebView> webView(AdoptNS, [[WebView alloc] initWithFrame:NSMakeRect(0, 0, 120, 200) frameName:nil groupName:nil]); You can use the adoptNS function instead for clarity. > Tools/TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm:55 > + RetainPtr<JSWrapperForNodeFrameLoadDelegate> frameLoadDelegate(AdoptNS, [JSWrapperForNodeFrameLoadDelegate new]); Ditto. Also use alloc/init instead of new. > Tools/TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm:82 > + JSStringRef isolatedPropertyJSString = JSStringCreateWithUTF8CString("isolatedProperty"); I think you can use a JSRetainPtr here, then you don't need to use JSStringRelease. > Tools/TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm:88 > + JSStringRef normalPropertyJSString = JSStringCreateWithUTF8CString("normalProperty"); I think you can use a JSRetainPtr here, then you don't need to use JSStringRelease.
Note You need to log in before you can comment on or make changes to this bug.