Bug 105247 – Chrome Android java output is too verbose

• Component: New Bugs
• Status: RESOLVED FIXED

[Yaron Friedman]

Chrome Android java output is too verbose

[Yaron Friedman]

Created attachment 179873 [details]
Patch

[Peter Beverloo]

Comment on attachment 179873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179873&action=review

Seems good to me, thanks Yaron. Please wait for Eric, Tony or someone else to do a formal review.

> Source/WebKit/chromium/ChangeLog:3
> +        Chrome Android java output is too verbose

nit for next time: Since this only touches Chromium files, we generally prefix the title with "[Chromium]".

[Tony Chang]

Comment on attachment 179873 [details]
Patch

Seems fine.

In the long run, you may want to put common command line flags into a variable and use that instead of having to duplicate the flags.  Another way to do this would be to make a .gypi for the action.  See build/grit_action.gypi for an example of this.

[Yaron Friedman]

There's actually a lot of shared infra on the chromium side (e.g. we have build/java_apk.gypi and testing/android/native_test.gyp). It wasn't clear to me whether we could use those in webkit.

[WebKit Review Bot]

Comment on attachment 179873 [details]
Patch

Rejecting attachment 179873 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Peter Beverloo]

Comment on attachment 179873 [details]
Patch

I'll look into that.

[WebKit Review Bot]

Comment on attachment 179873 [details]
Patch

Clearing flags on attachment: 179873

Committed r138044: <http://trac.webkit.org/changeset/138044>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Comment on attachment 179873 [details]
Patch

Fantastic! Thank you.

[Tony Chang]

(In reply to comment #4)
> There's actually a lot of shared infra on the chromium side (e.g. we have build/java_apk.gypi and testing/android/native_test.gyp). It wasn't clear to me whether we could use those in webkit.

You can use stuff on the chromium side, but it's normally frowned upon since it's annoying to make a change in chromium and learn a day later that it breaks something in WebKit.

Instead, what you could do is make a .gypi file in src/webkit/support that includes build/java_apk.gypi.  src/webkit/support is the API directory for things in WebKit that depend on chromium.  That way, if someone needs to change build/java_apk.gypi, it's possible to provide backwards compat for WebKit dependencies in src/webkit/support.

This might be too tricky.  The other option would be to just fork the build/java_apk.gypi file into WebKit.