Bug 105217

Summary: Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, pdr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Eric Seidel (no email)
Reported 2012-12-17 14:31:58 PST
Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
Attachments
Patch (3.57 KB, patch)
2012-12-17 14:34 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.57 KB, patch)
2012-12-17 14:38 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-12-17 14:34:03 PST
Created attachment 179804 [details] Patch
Dirk Pranke
Comment 2 2012-12-17 14:36:46 PST
Comment on attachment 179804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179804&action=review > Tools/Scripts/webkitpy/common/system/profiler.py:89 > + # FIXME: Currently all reports are kept as test.*, until we fix that, search more than 100 names before giving up. Nit: "search up to 1000 names" rather than "search more than 100 names" ? > Tools/Scripts/webkitpy/common/system/profiler.py:173 > + print # An extra line between tests looks nicer. Nit: I wouldn't bother w/ the comment here ...
Eric Seidel (no email)
Comment 3 2012-12-17 14:38:15 PST
Created attachment 179805 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-12-17 15:29:13 PST
Comment on attachment 179805 [details] Patch for landing Clearing flags on attachment: 179805 Committed r137952: <http://trac.webkit.org/changeset/137952>
WebKit Review Bot
Comment 5 2012-12-17 15:29:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.