Bug 105163
| Summary: | MediaQueryListListener should be implemented as custom binding | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ashvayka, haraken, luiz, oliver, pfeldman, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=203288 | ||
Yury Semikhatsky
MediaQueryListListener is the only client of ScriptCallback and it still uses VM-specific code guarded with #if USE(JSC). We should provide JSC and V8 implementations of MediaQueryListListener and get rid of ScriptCallback entirely.
I'm not sure if it is a problem but no connection between MediaQueryList and MediaQueryListListener is reported to the V8 garbage collector(unlike references between DOM node wrapper and its event listeners).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Shvayka
Closing this since r260243 removes MediaQueryListListener, and ScriptCallback is long gone.