Bug 105133

Summary: Bytecode dumping should show rare case profiles
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
sample profiling session
none
the patch
buildbot: commit-queue-
the patch
none
the patch ggaren: review+, buildbot: commit-queue-

Filip Pizlo
Reported 2012-12-16 12:18:10 PST
This is useful for the "profiling" command in the profiler, which dumps the profiling that the DFG saw at compile time.
Attachments
sample profiling session (6.33 KB, text/plain)
2012-12-16 12:21 PST, Filip Pizlo 		no flags
Details
the patch (37.45 KB, patch)
2012-12-16 12:22 PST, Filip Pizlo 		buildbot: commit-queue-
DetailsFormatted DiffDiff
the patch (37.56 KB, patch)
2012-12-16 13:05 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (37.56 KB, patch)
2012-12-16 13:13 PST, Filip Pizlo 		ggaren: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-12-16 12:21:27 PST
Created attachment 179656 [details] sample profiling session
Filip Pizlo
Comment 2 2012-12-16 12:22:18 PST
Created attachment 179657 [details] the patch
Build Bot
Comment 3 2012-12-16 12:50:18 PST
Comment on attachment 179657 [details] the patch Attachment 179657 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15371447
Filip Pizlo
Comment 4 2012-12-16 13:05:45 PST
Created attachment 179659 [details] the patch Fix no-value-profiling build
Filip Pizlo
Comment 5 2012-12-16 13:13:39 PST
Created attachment 179661 [details] the patch Fix a minor style issue I found.
Build Bot
Comment 6 2012-12-16 14:54:37 PST
Comment on attachment 179661 [details] the patch Attachment 179661 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15371485 New failing tests: fast/frames/sandboxed-iframe-attribute-parsing.html
Geoffrey Garen
Comment 7 2012-12-16 21:37:34 PST
Comment on attachment 179661 [details] the patch r=me
Filip Pizlo
Comment 8 2012-12-16 23:17:32 PST
Landed in http://trac.webkit.org/changeset/137878
Note You need to log in before you can comment on or make changes to this bug.