Bug 105059

Summary: Fix test breakage caused by r137765
Product: WebKit Reporter: yusufo
Component: New BugsAssignee: yusufo
Status: NEW    
Severity: Normal CC: jamesr, noel.gordon, yusufo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jamesr: review-

yusufo
Reported 2012-12-14 15:22:40 PST
Fix test breakage caused by r137765
Attachments
Patch (3.67 KB, patch)
2012-12-14 15:23 PST, yusufo 		no flags
DetailsFormatted DiffDiff
Patch (3.79 KB, patch)
2012-12-14 15:45 PST, yusufo 		jamesr: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yusufo
Comment 1 2012-12-14 15:23:36 PST
Created attachment 179541 [details] Patch
yusufo
Comment 2 2012-12-14 15:24:16 PST
Testing locally to verify.
yusufo
Comment 3 2012-12-14 15:45:10 PST
Created attachment 179545 [details] Patch
yusufo
Comment 4 2012-12-14 15:45:45 PST
Verified that this fixes all 5 tests
James Robinson
Comment 5 2012-12-14 15:58:21 PST
Comment on attachment 179545 [details] Patch Either the comments in this patch are wrong or we broke behavior in the previous patch.
James Robinson
Comment 6 2012-12-14 16:00:27 PST
Oh! I'll bet you aren't setting m_flingActiveOnMainThread in the transfer case. So r137765 *did* break behavior we care about. Fix that up and it'll fix the tests.
Note You need to log in before you can comment on or make changes to this bug.