Bug 105052

Summary: Allow the text track contents to be displayed externally to WebCore.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch eric.carlson: review+

Jer Noble
Reported 2012-12-14 12:54:20 PST
Allow the text track contents to be displayed externally to WebCore.
Attachments
Patch (26.65 KB, patch)
2012-12-14 13:11 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (26.68 KB, patch)
2012-12-14 13:22 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (26.69 KB, patch)
2012-12-14 13:37 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-12-14 13:11:43 PST
Created attachment 179520 [details] Patch
Jer Noble
Comment 2 2012-12-14 13:22:58 PST
Created attachment 179525 [details] Patch Rebaselined.
Jer Noble
Comment 3 2012-12-14 13:37:01 PST
Created attachment 179528 [details] Patch Use nullptr instead of 0 when clearing an OwnPtr (fixes Chromium build error).
Eric Carlson
Comment 4 2012-12-14 13:40:58 PST
Comment on attachment 179528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179528&action=review > Source/WebCore/html/shadow/MediaControlElements.cpp:1290 > hasChildNodes() ? show() : hide(); > + > + if (hasChildNodes()) { You might as well combine these (only call hasChildNodes once). > Source/WebCore/platform/graphics/MediaPlayerPrivate.h:188 > + virtual bool requiresTextTrackRepresentation() const { return 0; } Nit: "return 0" -> "return false"
Jer Noble
Comment 5 2012-12-14 15:25:05 PST
Committed r137782: <http://trac.webkit.org/changeset/137782>
Note You need to log in before you can comment on or make changes to this bug.