Bug 105045

Summary: Enable video caption controls on Windows.
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, eric.carlson, eric, feature-media-reviews, ojan.autocc, roger_fong, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch eric.carlson: review+

Roger Fong
Reported 2012-12-14 12:00:41 PST
Now that video tracks have been enabled on Windows, enable controls as well.
Attachments
patch (3.05 KB, patch)
2012-12-14 12:05 PST, Roger Fong 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2012-12-14 12:05:05 PST
Created attachment 179510 [details] patch controls work manually but video-controls-captions-trackmenu.html times out for some reason. Investigating but enabling controls first for now.
Eric Carlson
Comment 2 2012-12-14 13:49:59 PST
Comment on attachment 179510 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=179510&action=review > Source/WebCore/rendering/RenderThemeWin.h:28 > +#include <SafariTheme/SafariThemeConstants.h> Is this change needed?
Roger Fong
Comment 3 2012-12-14 14:12:30 PST
(In reply to comment #2) > (From update of attachment 179510 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179510&action=review > > > Source/WebCore/rendering/RenderThemeWin.h:28 > > +#include <SafariTheme/SafariThemeConstants.h> > > Is this change needed? Yeah it's to get supportsClosedCaptioning() in RenderThemeWin to return true. It checks to see that SAFARI_THEME_VERSION >= 4 which is defined in the constants file. RenderThemeSafari includes SafariThemeConstants but it looks like it was missed in RenderThemeWin.
Roger Fong
Comment 4 2012-12-14 14:22:28 PST
http://trac.webkit.org/changeset/137771
Note You need to log in before you can comment on or make changes to this bug.