Bug 105032

Summary: Web Inspector: Fix JS compiler warning.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Eugene Klyuchnikov
Reported 2012-12-14 08:19:37 PST
JS compiler output: Source/WebCore/inspector/front-end/ElementsTreeOutline.js:484: WARNING - actual parameter 1 of WebInspector.KeyboardShortcut.hasNoModifiers does not match formal parameter found : (Event|null) required: (KeyboardEvent|null) if (!treeElement._editing && WebInspector.KeyboardShortcut.hasNoModifiers(event) && event.keyCode === WebInspector.KeyboardShortcut.Keys.H.code) {
Attachments
Patch (1.99 KB, patch)
2012-12-14 08:29 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (1.97 KB, patch)
2012-12-16 21:19 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2012-12-14 08:29:35 PST
Created attachment 179488 [details] Patch
Pavel Feldman
Comment 2 2012-12-14 09:53:43 PST
Comment on attachment 179488 [details] Patch I'd rather cast event to keyboardevent in the handler.
Eugene Klyuchnikov
Comment 3 2012-12-16 21:19:45 PST
Created attachment 179687 [details] Patch
Eugene Klyuchnikov
Comment 4 2012-12-16 21:21:41 PST
(In reply to comment #2) > (From update of attachment 179488 [details]) > I'd rather cast event to keyboardevent in the handler. Done.
WebKit Review Bot
Comment 5 2012-12-16 23:14:44 PST
Comment on attachment 179687 [details] Patch Clearing flags on attachment: 179687 Committed r137877: <http://trac.webkit.org/changeset/137877>
WebKit Review Bot
Comment 6 2012-12-16 23:14:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.