Bug 105024

Summary:

Web Inspector: Provide the paint count of layers through the LayerTreeAgent

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Web Inspector (Deprecated)

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, joepeck, keishi, loislo, pfeldman, pmuellr, timothy, vsevik, web-inspector-bugs, webkit-bug-importer, webkit.review.bot, yurys

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Antoine Quint

Reported 2012-12-14 07:33:51 PST

Another good piece of information about a layer is to show the redraw count for this layer. This would allow the Web Inspector to quickly show layers that redraw a lot and let the developer identify easily what may be causing performance issues.

Attachments
Patch (8.01 KB, patch) 2012-12-17 08:01 PST, Antoine Quint	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2012-12-14 07:34:15 PST

<rdar://problem/12882763>

Antoine Quint

Comment 2 2012-12-14 07:41:45 PST

I don't think it's worth adding a new method to the agent for this as paint counts will update as the layer tree changes, so the existing layerTreeDidChange events will already inform of the change and it should be cheap to get the redraw count from the GraphicsLayer associated with the RenderLayer. Simply adding a new .paintCount property on the Layer object in InspectorLayerTreeAgent::buildObjectForLayer() should be sufficient.

Antoine Quint

Comment 3 2012-12-17 07:28:44 PST

Also raised https://bugs.webkit.org/show_bug.cgi?id=105178, which is about ensuring a new property to show paint counts is indeed accurate.

Antoine Quint

Comment 4 2012-12-17 08:01:42 PST

Created attachment 179745 [details] Patch

WebKit Review Bot

Comment 5 2012-12-17 08:58:21 PST

Comment on attachment 179745 [details] Patch Clearing flags on attachment: 179745 Committed r137913: <http://trac.webkit.org/changeset/137913>

WebKit Review Bot

Comment 6 2012-12-17 08:58:24 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.